Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Bump sinon from 2.0.0 to 4.2.2 in /build #30293

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps sinon from 2.0.0 to 4.2.2.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If you'd like to skip this version, you can just close this PR. If you have any feedback just mention @dependabot in the comments below.

@phil-davis phil-davis changed the title Bump sinon from 2.0.0 to 4.2.2 in /build [master] Bump sinon from 2.0.0 to 4.2.2 in /build Feb 8, 2018
@PVince81 PVince81 self-assigned this Feb 9, 2018
@PVince81
Copy link
Contributor

PVince81 commented Feb 9, 2018

Looking into this... some weird behavior

@PVince81
Copy link
Contributor

PVince81 commented Feb 9, 2018

I wonder if it's a bug in the spies from Sinon 4... Now when accessing the thisValue I get a proxy instead of the original object so triggering an event on it doesn't have any handlers...

Might need to try and find another alternative way to do this

@PVince81
Copy link
Contributor

PVince81 commented Feb 9, 2018

Possibly a regression in sinon, reported upstream: sinonjs/sinon#1683

@PVince81
Copy link
Contributor

PVince81 commented Feb 9, 2018

There is likely another way but let's wait a bit for upstream to confirm

@dependabot-preview
Copy link
Contributor Author

Superseded by #30460.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/build/sinon-4.2.2 branch February 12, 2018 22:12
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants